Messages in this thread | | | Date | Tue, 18 May 1999 14:52:08 +0300 (EET DST) | From | Kai Makisara <> | Subject | Re: [2.3.3] error in st.c |
| |
On Mon, 17 May 1999, Scott Sibert wrote:
> Compiling 2.3.3 I get: > > make[2]: Entering directory `/o2/233/linux/drivers/scsi' > gcc -D__KERNEL__ -I/o2/233/linux/include -Wall -Wstrict-prototypes -O2 > -fomit-frame-pointer -pipe -fno-strength-reduce -march=pentium > -mcpu=pentium -DCPU=586 -DMODULE -DMODVERSIONS -include > /o2/233/linux/include/linux/modversions.h -c -o st.o st.c > st.c: In function `st_attach': > st.c:3383: incompatible types in assignment > make[2]: *** [st.o] Error 1 > make[2]: Leaving directory `/o2/233/linux/drivers/scsi' > make[1]: *** [_modsubdir_scsi] Error 2 > make[1]: Leaving directory `/o2/233/linux/drivers' > make: *** [_mod_drivers] Error 2 > > > > Line in question: > > ... > tpnt->devt = MKDEV(SCSI_TAPE_MAJOR, i); > tpnt->dirty = 0; > -> tpnt->waiting = NULL; > tpnt->in_use = 0; ...
This is not the correct way to initialise the wait queue (it should be done with init_waitqueue_head()). However, the simplest fix is to remove this line and the definition of waiting in st.h (the wait queue has been unused for quite a long time ;-).
Kai
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |