Messages in this thread | | | Date | Tue, 30 Mar 1999 09:08:22 +0200 (MET DST) | From | David Weinehall <> | Subject | Re: [PATCH] linux/net/ipv4/arp.c, kernel 2.0.36 (& 2.0.37-pre9) |
| |
On Mon, 29 Mar 1999, Alan Cox wrote:
> > > The kernel knows perfectly well that its silly to send packets to yourself > > > via external interfaces. This patch isn't needed. The bug is your routing > > > table and trying to set up this configuration. > > > > Alan, this bitten me long time ago, too. External loopback is very > > nice for testing... > > There are two reasons Im not putting this in > > 1. Its a very specialised need. The patch is fine if you need it add it - its > more specialised than other "not needed" patches people keep out of the > main tree. > > 2. Its on a common code path. Sum the number of times that path is taken > by the number of users of Linux versus the 3 or 4 who actually need it. > > There isnt anything wrong with the patch, its just not relevant to the > userbase as a whole and its on a regularly executed path
Would it not be possible to make this behaviour config'able, so that the faster code-path is default, and you have to specifically choose to compile in the loopback behaviour?!
This way, it won't lead to any overhead (apart from maybe a few hundred bytes...)
/David Weinehall _ _ // David Weinehall <tao@acc.umu.se> /> Northern lights wander \\ // Project MCA Linux hacker // Dance across the winter sky // \> http://www.acc.umu.se/~tao/ </ Full colour fire </
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |