lkml.org 
[lkml]   [1999]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Some patches to compile 2.3.30pre3
On Tue, 30 Nov 1999, Sergey Kubushin wrote:

> diff -urN linux-2.3.30pre3.orig/drivers/char/pc110pad.c linux-2.3.30pre3/drivers/char/pc110pad.c
> --- linux-2.3.30pre3.orig/drivers/char/pc110pad.c Mon Oct 11 20:10:19 1999
> +++ linux-2.3.30pre3/drivers/char/pc110pad.c Tue Nov 30 13:31:02 1999
> @@ -53,7 +53,6 @@
> static wait_queue_head_t queue;
> static struct fasync_struct *asyncptr;
> static int active=0; /* number of concurrent open()s */
> -static struct semaphore read_lock;
>
> /*
> * Utility to reset a timer to go off some time in the future.

This is wrong -- read_lock must be a private variable for that driver (it
used to be a macro, but is now an inline function to help catch certain
bugs in code using spinlocks). Could you rename it to something else (say
pc110_lock) everywhere within that driver?

-ben


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:55    [W:0.040 / U:1.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site