Messages in this thread Patch in this message | | | Subject | Re: linuxppc modular sound patch | From | Jes Sorensen <> | Date | 14 Nov 1999 11:31:02 +0100 |
| |
>>>>> "Takashi" == Takashi Oe <toe@unlserve.unl.edu> writes:
Takashi> On Fri, 12 Nov 1999, brandon wrote: >> sorry, assuming that my previous email with patch was the correct >> thing to do, there must be another bug that has to do with >> dynamically allocating interrupts.
Takashi> I thought this bug was fixed a long time ago. Attached patch Takashi> should fix it.
This seems wrong:
diff -urN vger-991109/dmasound.c dmasound-991113/dmasound.c --- vger-991109/dmasound.c Fri Aug 20 21:32:41 1999 +++ dmasound-991113/dmasound.c Sun Nov 14 04:14:19 1999 @@ -3003,8 +3003,10 @@ static int __init PMacIrqInit(void) { - if (request_irq(awacs_irq, pmac_awacs_intr, 0, "AWACS", 0) - || request_irq(awacs_tx_irq, pmac_awacs_tx_intr, 0, "AWACS out", 0)) + if (request_irq(awacs_irq, pmac_awacs_intr, 0, "AWACS", + (void *)awacs) + || request_irq(awacs_tx_irq, pmac_awacs_tx_intr, 0, "AWACS out", + (void *)awacs)) return 0; return 1; } You are passing the same pointer as the data pointer to the interrupt allocation. This pointer is also used to distinguish registerred interrupt handlers in case multiple handlers are assigned the same interrupt number.
Jes
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |