> > It should be ok SMP - it could be more polite thats all
> 
> Any quick pointers on this? (Pointer to parts of other drivers that
> are 'nicer' would be great). I'm going to add a second CPU to this P2
> soon, so I will have some (minor) incentive to improve things here.

Basically it hogs the kernel lock. Much of that code could do
an unlock_kernel()/lock_kernel()


> breaking Connectix scheme (reset and try to handshake). I don't have a
> printer hooked up though, so it's on the 'possibly nice to make time
> for' pile.

True

> I guess I missed '5. V4L2 compatability' too.

Let the API settle first

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/