[lkml]   [1999]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PROGRESS!] A simple way to lock up 2.2.0-pre7

Good debugging, I'm thankful and impressed.

In article <>,
Mike Galbraith <> wrote:
> 925 add_wait_queue(&tty->read_wait, &wait);
> 926
> 927 if (down_interruptible(&tty->atomic_read)) {
> 928 remove_wait_queue(&tty->read_wait, &wait); /*MIKEDIDIT*/
> 929 return -ERESTARTSYS;
> 930 }

I would suggest the simpler fix of just moving the "add_wait_queue()"
until after the down_interruptible test - that way there is nothing to
remove, and we really only want the read_wait queue to be around the
while-loop that follows.

Anyway, thanks for noticing and fixing it,


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:49    [W:0.058 / U:6.072 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site