lkml.org 
[lkml]   [1999]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PROGRESS!] A simple way to lock up 2.2.0-pre7
    Date
    Bingo!

    Good debugging, I'm thankful and impressed.

    In article <Pine.LNX.4.02A.9901170751140.4394-100000@mikeg.weiden.de>,
    Mike Galbraith <mikeg@weiden.de> wrote:
    >
    > 925 add_wait_queue(&tty->read_wait, &wait);
    > 926
    > 927 if (down_interruptible(&tty->atomic_read)) {
    > 928 remove_wait_queue(&tty->read_wait, &wait); /*MIKEDIDIT*/
    > 929 return -ERESTARTSYS;
    > 930 }

    I would suggest the simpler fix of just moving the "add_wait_queue()"
    until after the down_interruptible test - that way there is nothing to
    remove, and we really only want the read_wait queue to be around the
    while-loop that follows.

    Anyway, thanks for noticing and fixing it,

    Linus

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.rutgers.edu
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:49    [W:0.029 / U:58.672 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site