Messages in this thread | | | Date | Mon, 21 Sep 1998 07:07:33 -0400 (EDT) | From | "Steven N. Hirsch" <> | Subject | Re: Please test knfsd-980920 |
| |
On Sun, 20 Sep 1998, H.J. Lu wrote:
> All known knfs bugs are fixed. I made quite a few changes. Please > check it out. When you report a bug, please tell me exactly how > to reproduce the bug. Please don't assume anything. > > Thanks. > > H.J. > ---
H.J.,
The problem of advertising NFS v3 services for mountd persists. This breaks at least one older client machine here. Again, in my opinion it makes no sense to advertise NFS v3 mount and statd services when we have no actual v3 nfsd support.
If you do not feel that this patch should go in, would you at least give me a rationale for not doing so?
Steve
*** utils/mountd/mountd.c.oem Thu Sep 10 13:19:28 1998 --- utils/mountd/mountd.c Sat Sep 12 14:01:19 1998 *************** *** 18,23 **** --- 18,28 ---- #include "rpcmisc.h" #include "version.h" + /* There's no point in having mountd advertise V3 services when the + * server itself doesn't handle it. Some clients have a very hard + * hard time with this discrepancy. + */ + #undef NFS3 static void usage(int exitcode); static exports get_exportlist(void); *************** *** 41,47 **** --- 46,54 ---- { pmap_unset (MOUNTPROG, MOUNTVERS); pmap_unset (MOUNTPROG, MOUNTVERS_POSIX); + #ifdef NFS3 pmap_unset (MOUNTPROG, MOUNTVERS_NFSV3); + #endif xlog (L_FATAL, "Caught signal %d, un-registering and exiting.", sig); } *************** *** 323,330 **** rpc_init("mountd", MOUNTPROG, MOUNTVERS, mount_dispatch, 0, 0); rpc_init("mountd", MOUNTPROG, MOUNTVERS_POSIX, mount_dispatch, 0, 0); rpc_init("mountd", MOUNTPROG, MOUNTVERS_NFSV3, mount_dispatch, 0, 0); ! sa.sa_handler = killer; sigaction(SIGHUP, &sa, NULL); sigaction(SIGINT, &sa, NULL); --- 342,350 ---- rpc_init("mountd", MOUNTPROG, MOUNTVERS, mount_dispatch, 0, 0); rpc_init("mountd", MOUNTPROG, MOUNTVERS_POSIX, mount_dispatch, 0, 0); + #ifdef NFS3 rpc_init("mountd", MOUNTPROG, MOUNTVERS_NFSV3, mount_dispatch, 0, 0); ! #endif sa.sa_handler = killer; sigaction(SIGHUP, &sa, NULL); sigaction(SIGINT, &sa, NULL);
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |