Messages in this thread | | | Date | Wed, 16 Sep 1998 19:10:39 +0300 (EET DST) | From | Jukka Tapani Santala <> | Subject | Re: [PATCH] Speeding up FAT operations |
| |
On Wed, 16 Sep 1998, Jukka Tapani Santala wrote: > work, it suddenly struck to me that I have "The Programmers PC > Sourcebook", 2nd edition, in my bookshelf. According to this, Microsoft
Page 2-27, table 2.23, "DISK BOOT RECORD LAYOUT": "Offset D(13), word, Sectors per cluster (must be a power of 2)" - sidenote "DOS 3.3, 4.4 and 5.0 boot sector structure" (Sorry, the original table is nicely formatted) Source listed: IBM DOS 3.3 Technical Reference, page 2-31; Microsoft MS-DOS 4.0 Programmer's Reference, pages 337 through 338; Microsoft MS-DOS 5.0 Programmer's Reference, pages 34 through 35. The sourcebook is generally reliable with a few odd typoes here and there, but it's doubtful this will fall in that category.
The real reason I replied to myself is to note that there's a little bug in the patch: -#define MSDOS_CAN_BMAP(mib) (!(((mib)->cluster_size & 1) || \ +#define MSDOS_CAN_BMAP(mib) (!(((mib)->cluster_shift != 0) || \
I hope people noticed this is inverse to what is desired ;) This bug is noncritical, since as the comments say, MSDOS_CAN_BMAP is an obsolete macro that isn't actually even used. I didn't pay enough attention to it because of that, but since it's still in the code, on the off change that somebody takes it into use again, that check should (probably - I have no idea what it's trying to do given it's unused) be == 0. Not posting another patch at this time as it's a trivial issue, and I've already posted two versions of it today, though ;)
-Donwulff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |