Messages in this thread | | | Date | Mon, 3 Aug 1998 10:30:12 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: page_alloc strange mask += mask |
| |
On Mon, 3 Aug 1998, Andrea Arcangeli wrote: > > Continuing my trail in the mm internals I didn' t understood this point > (and a lot of other things of course ;-). Using mask += mask some low bits > got lost by the mask. Was that intentional?
It was very much intentional. The mask should go like
11111111111111111111000000000000 11111111111111111110000000000000 11111111111111111100000000000000 ....
and your patch makes it
11111111111111111111000000000000 11111111111111111110000000000001 11111111111111111100000000000011 ...
which probably happens to work because the low bits aren't really significant as they have been masked out by the earlier passes, but it's not correct.
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html
| |