Messages in this thread | | | Subject | Re: 2.1.114 linux/include/linux/sched.h problem - followup | From | Andi Kleen <> | Date | 04 Aug 1998 01:26:28 +0200 |
| |
alan@lxorguk.ukuu.org.uk (Alan Cox) writes:
> > >compilation for the non-SMP case. What's the correct fix? > > >Unconditionally define INIT_LOCKS to be SPIN_LOCK_UNLOCKED? > > > > Nope. That won't cut it. DaveM's comment about some versions of gcc > > dumping core when an empty structure constant is parsed at the end of > > a large top level structure initialization definitely applies to > > gcc-2.7.2.3. gcc-2.8.1 is fine, and I would assume that egcs compilers > > are probably ok as well. > > Since our string code is still capable of generating invalid code with > gcc 2.8.1/egcs that doesn't seem to be a valid answer either ;)
Maybe the dreaded asm/string.h should be just removed, except for memcpy()/memmove()/memset(). All other string functions are either not performance criticial or not used at all (strtok, strspn, ..) - so they could be implemented in C -, or already better supported by gcc by using the __builtin_* variants.
-Andi (who thinks most of asm/string.h is just an anachronism)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html
| |