lkml.org 
[lkml]   [1998]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: when will we ever learn...
    On Wed, 26 Aug 1998, David S. Miller wrote:
    > That one cannot perform bitops on a char...
    >
    > --- mm/swapfile.c.~3~ Wed Aug 26 00:05:02 1998
    > +++ mm/swapfile.c Wed Aug 26 02:42:19 1998
    > @@ -489,7 +489,7 @@
    > int swap_header_version;
    > int lock_map_size = PAGE_SIZE;
    > int nr_good_pages = 0;
    > - char tmp_lock_map = 0;
    > + unsigned long tmp_lock_map = 0;
    >
    > lock_kernel();
    > if (!capable(CAP_SYS_ADMIN))

    The day we're allowed to change the arguments of the bitops prototypes from

    volatile void *

    to

    volatile unsigned long *

    Last time I suggested that on linux-kernel, people strongly objected against
    that...

    Greetings,

    Geert

    --
    Geert Uytterhoeven Geert.Uytterhoeven@cs.kuleuven.ac.be
    Wavelets, Linux/{m68k~Amiga,PPC~CHRP} http://www.cs.kuleuven.ac.be/~geert/
    Department of Computer Science -- Katholieke Universiteit Leuven -- Belgium


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.rutgers.edu
    Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html

    \
     
     \ /
      Last update: 2005-03-22 13:44    [W:0.018 / U:90.404 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site