Messages in this thread | | | Date | Mon, 17 Aug 1998 11:54:26 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: new kmod patch (against 2.1.115) |
| |
On Mon, 17 Aug 1998, Greg Zornetzer wrote: > { > char *argv[] = { modprobe_path, "-s", "-k", (char*)module_name, NULL}; > int i; > + char * envp[] = { "HOME=/", "TERM=linux", "PATH=/sbin:/usr/sbin:/bin:/usr/bin", NULL }; > + /* The MMU ATC entries need flushing somewhere round here. This > + thread was created with CLONE_VM, so there was no cause to > + flush it there. exec_mmap() called as a result of the following > + execve() finds current->mm->count=2, so that doesn't flush the MMU > + either. */ > + > + flush_tlb_mm(current->mm); > + > > use_init_file_context(); >
Any patch with this will NOT be accepted. I've told multiple people about it, and any architecture that needs this is BROKEN. Not just for kmod, but for everything else.
The architecture-specific macros for slushing and initializing a new pgtable context had better flush the TLB. If they don't, they are broken. As far as I know, the m68k port is broken in this regard, and instead of the m68k people letting broken patches like this float around they should just fix their activate_context() macros or whatever.
Please don't send this patch to me again. Sending it multiple times just makes me irritated, and won't make it any more likely to get included.
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html
| |