lkml.org 
[lkml]   [1998]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: bad patches (was: Patches vs complete tarballs....)
Date
From
Albert D. Cahalan wrote:
>
> diff -u --recursive --new-file v2.1.114/linux/CREDITS linux/CREDITS
> --- v2.1.114/linux/CREDITS Tue Jul 21 00:15:29 1998
> +++ linux/CREDITS Thu Aug 6 11:13:43 1998
>
> Count the number of slashes in each name. You will see that they are
> not the same, which is bad. Patching results will vary with the version
> of the patch program that you use.
>
> Good: 1/2/3/4/foo.c paired with a/b/c/d/foo.c
> Bad: 1/2/3/4/foo.c paired with x/y/z/foo.c
>
> Fixed header:
>
> diff -u --recursive --new-file v2.1.114/linux/CREDITS v2.1.115/linux/CREDITS
> --- v2.1.114/linux/CREDITS Tue Jul 21 00:15:29 1998
> +++ v2.1.115/linux/CREDITS Thu Aug 6 11:13:43 1998
>

Guys, can we please shut up about this?

- Linus makes the patches, he does them as he sees fit.
- The way they are they are perfectly fine for many, many people.
- I've never seen a "patch program" that takes the wrong line from
the header. You need reasonably recent tools to make Linux kenels.
Patch might be one of the programs that needs to be "recent".
- The person that started this thread certainly didn't read the docs and
was using the wrong commandline args to "patch".

- If you really want, add
sed -e 's/+++ linux/+++ v2.1.115\/linux/'
to your gunzip/patch command line.

Problem solved Lets get on with it OK?

Roger.

--
| The secret of success is sincerity. Once you can | R.E.Wolff@BitWizard.nl
| fake that, you've got it made. -- Jean Giraudoux | T: +31-15-2137555
- Custom Linux device drivers for sale! Call for a quote. - F: +31-15-2138217

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html

\
 
 \ /
  Last update: 2005-03-22 13:44    [from the cache]
©2003-2011 Jasper Spaans