lkml.org 
[lkml]   [1998]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: piss poor change in ncr53c8xx/linux-2.1.104
  Date: 	Mon, 8 Jun 1998 21:52:29 +0200 (MET DST)
From: Gerard Roudier <groudier@club-internet.fr>

#define mdelay(n) \
panic("Better to die than wasting memory and CPU stupidly\")

I am not going to use this useless thing that is designed to waste memory
and CPU at the same time.

FYI, the ncr driver has never used more that 1000 as argument to
udelay(). It is not my fault if lots of other kernel modules did'nt
use udelay() as it was required.

A while back before using udelay I tested its range of accuracy. As I recall,
it was certainly reasonable up to 100000 or so.

Please, stop wasting my time with so obvious stuff as mdelay().

THAT'S ALL.

I want to add my voice to Gerard's on this issue. I found gratuitous changes
from udelay(1000) to mdelay(1) made to the BusLogic driver in a pre-patch, and
I immediately asked Linus to remove that change. If there were a good reason
for using mdelay instead of udelay in this case, I might be convinced to change
the code, but failing that I see no reason to do so.

In general, I consider it discourteous to send patches for code owned and
maintained by someone else directly for inclusion in the kernel rather than to
the author, except perhaps for critical bugs.

Leonard

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu

\
 
 \ /
  Last update: 2005-03-22 13:43    [W:0.047 / U:2.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site