Messages in this thread | | | Date | Fri, 29 May 1998 15:38:14 +0200 | From | Pavel Machek <> | Subject | Re: cli/sti in char/vt.c [patch] |
| |
Hi!
> The following patch (against 2.1.103) attempts to fix that. I believe it > also makes it SMP safe, but I only have a UP, so can't test.
Don't think so. Well, it is safe on i386, but on other architectures, test_and_set_bit is not guaranteed to be atomic. [And I'm afraid that this code is used on non-i386 but similar hw around machines?]
You should better use atomic_t mksound_lock, and atomic_inc/atomic_dec.
Correct and post to linus ;-)
Pavel
-- I'm really pavel@atrey.karlin.mff.cuni.cz. Pavel Look at http://atrey.karlin.mff.cuni.cz/~pavel/ ;-).
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu
| |