lkml.org 
[lkml]   [1998]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: cli/sti in char/vt.c [patch]
Hi!

> The following patch (against 2.1.103) attempts to fix that. I believe it
> also makes it SMP safe, but I only have a UP, so can't test.

Don't think so. Well, it is safe on i386, but on other architectures,
test_and_set_bit is not guaranteed to be atomic. [And I'm afraid that
this code is used on non-i386 but similar hw around machines?]

You should better use atomic_t mksound_lock, and
atomic_inc/atomic_dec.

Correct and post to linus ;-)

Pavel

--
I'm really pavel@atrey.karlin.mff.cuni.cz. Pavel
Look at http://atrey.karlin.mff.cuni.cz/~pavel/ ;-).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu

\
 
 \ /
  Last update: 2005-03-22 13:42    [W:0.134 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site