lkml.org 
[lkml]   [1998]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-2.1.92-2 for i386: Are the assembly suffixes really OK?
On Tue, 31 Mar 1998, Horst von Brand wrote:

> There are lots of lines like the following in the patch(this if from the
> patch to arch/i386/kernel/head.S):
>
>
> - mov %dx,%ds; \
> - mov %dx,%es;
> + movl %dx,%ds; \
> + movl %dx,%es;
>
> While the patch to arch/i386/kernel/traps.c reads in part:
>
> #define get_seg_byte(seg,addr) ({ \
> register unsigned char __res; \
> -__asm__("push %%fs;mov %%ax,%%fs;movb %%fs:%2,%%al;pop %%fs" \
> +__asm__("pushl %%fs;movl %%ax,%%fs;movb %%fs:%2,%%al;popl %%fs" \
> :"=a" (__res):"0" (seg),"m" (*(addr))); \
> __res;})
>
> I might be totally off base here, but shouldn't all (most?) of these be
> "movw", not "movl" (16 bit moves, not 32 bit ones)?
>
> There are lots and lots of changes like this...

(presuming that you're talking about the Alan Modra patch)

Well, I'll leave the should bees to those more intimate with assembler.
What I can say is the patch works fine here so far.

-Mike


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu

\
 
 \ /
  Last update: 2005-03-22 13:42    [W:0.166 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site