Messages in this thread Patch in this message | | | Date | Fri, 10 Apr 1998 21:58:41 +0100 (BST) | From | Riley Williams <> | Subject | Re: Linux configuration scripts patches |
| |
Hi there.
First of all, some of the domains listed above bounced this message with the explanation "Request is invalid", so I have to assume that some of the authors listed have different addresses to those given. If so, can somebody please advise what the correct addresses are, and forward this message to them...
> Regarding the various Linux configuration scripts, one problem that > I've noticed is that several of the help texts appear difficult to > read simply because they are displayed as one large lump of text > rather than being split into separate paragraphs.
===8<=== CUT ===>8===
A minor bug in the patch has been pointed out to me: The original patch as shown would change ANY line consisting only of a single non-whitespace character into a blank line, rather than just those consisting of a single dot, and is caused by the fact that sed uses regular expression matching with . as a character wildcard. The only change required to implement the declared behaviour is to escape the dot in each patch with a backstroke.
The modified patch is provided below...
> AXEL: If this patch gets accepted, you may like to revise the help > texts accordingly to make them much easier to read...
Still true...
> Best wishes from Riley.
**************************************************************************
--- scripts/Configure.orig Fri Apr 10 12:46:10 1998 +++ scripts/Configure Fri Apr 10 12:48:51 1998 @@ -49,6 +49,10 @@ # 040697 Larry Augustin (lma@varesearch.com) - integer expr test # fails with GNU expr 1.12. Re-write to work with new and old expr.
+# 100498 Riley Williams (rhw@bigfoot.com) - added ability to display +# blank lines in help texts: Any line consisting only of a single dot +# will be displayed blank. + # # Make sure we're really running bash. # @@ -96,7 +100,7 @@ then echo; echo " Sorry, no help available for this option yet.";echo else - (echo; echo "$text"; echo) | ${PAGER:-more} + (echo; echo "$text"; echo) | sed 's/^\.$//' | ${PAGER:-more} fi else echo; --- scripts/Menuconfig.orig Fri Apr 10 12:38:49 1998 +++ scripts/Menuconfig Fri Apr 10 12:42:59 1998 @@ -22,6 +22,12 @@ # Please send comments / questions / bug fixes to roadcapw@titus.org # #---------------------------------------------------------------------------- +# +# 10 Apr 1998 - Added ability to display blank lines in help text: Any line +# which only contains a single dot will be displayed blank. +# Author: Riley Williams <rhw@bigfoot.com> +# +#----------------------------------------------------------------------------
# # Make sure we're really running bash. @@ -229,7 +235,7 @@ echo "There is no help available for this kernel option." return 1 else - echo "$text" + echo "$text" | sed 's/^\.$//' fi else echo "There is no help available for this kernel option." --- END OF PATCH
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu
| |