lkml.org 
[lkml]   [1998]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: pre-2.1.132-2..

On Fri, 18 Dec 1998, Andrea Arcangeli wrote:

> This patch remove the unused bits. I don' t know what they are used for...
> Maybe for alignment, but without them the irq_desc_t struct is just 32*4
> bits so it seems just word aligned to me...

> struct hw_interrupt_type *handler; /* handle/enable/disable functions */
> struct irqaction *action; /* IRQ action list */
> unsigned int depth; /* Disable depth for nested irq disables */
> - unsigned int unused[2];

NO! :) On SMP, with shared data structures, we want to have 1 structure
per cacheline, otherwise we'd just play cacheline ping-pong for no good
reason.

on nonshared/UP data structures we want to have word alignment, correct.

(the padding is wrong in both cases btw, unless i cant count (damn, where
was that calculator). We need unused[5])

-- mingo


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:46    [W:0.362 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site