lkml.org 
[lkml]   [1998]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subjectnfs patch for NetApp snapshot
Can someone comment on the attached patch?

Basically, 2.1.131 works fine with .snapshot directories at the mount
point, but not in subdirectories. My patch removes the test
IS_ROOT(...). With the patch, subdirectories seem to work fine.

Why is the IS_ROOT(...) there at all?

--Lee Hetherington
--- fs/nfs/inode.c.orig Fri Dec 18 13:17:42 1998
+++ fs/nfs/inode.c Fri Dec 18 13:56:44 1998
@@ -474,7 +474,7 @@
* unhashed inode to avoid aliasing problems.
*/
if ((dentry->d_parent->d_inode->u.nfs_i.flags & NFS_IS_SNAPSHOT) ||
- (IS_ROOT(dentry->d_parent) && dentry->d_name.len == 9 &&
+ (dentry->d_name.len == 9 &&
memcmp(dentry->d_name.name, ".snapshot", 9) == 0)) {
struct inode *inode = get_empty_inode();
if (!inode)
\
 
 \ /
  Last update: 2005-03-22 13:46    [from the cache]
©2003-2011 Jasper Spaans