lkml.org 
[lkml]   [1998]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] my latest oom stuff
    Hi,

    Andrea, would you --- and everybody else who touches sysctl.h: *PLEASE*
    read the comments at the top of that file, and fix your patch.

    On Wed, 4 Nov 1998 17:09:09 +0100 (CET), Andrea Arcangeli
    <andrea@e-mind.com> said:

    > --- linux/include/linux/sysctl.h:1.1.1.3 Sat Oct 31 01:16:09 1998
    > +++ linux/include/linux/sysctl.h Sat Oct 31 01:36:44 1998
    > @@ -93,7 +93,6 @@
    > enum
    > {
    > /*1*/ VM_SWAPCTL=1, /* struct: Set vm swapping control */
    > - VM_SWAPOUT, /* int: Background pageout interval */
    > VM_FREEPG, /* struct: Set free page thresholds */
    > VM_BDFLUSH, /* struct: Control buffer cache flushing */
    > VM_OVERCOMMIT_MEMORY, /* Turn off the virtual memory safety limit */

    What this does is to renumber all the subsequent labels for a the binary
    sysctl(2) interface, totally breaking the ABI.

    I initially wrote this file in terms of #defines, not enums, explicitly
    because it is harder to mess up the numbering that way. I don't know
    who changed it to enums in 2.1, or why, but I've had to keep patching
    the interface ever since: it's probably time I replaced it with #defines
    again. :(

    --Stephen

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.rutgers.edu
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:45    [W:3.959 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site