Messages in this thread Patch in this message | | | From | Jakub Jelinek <> | Subject | Re: [PATCH] CONFIG_SMP available for 2.1.125 | Date | Sun, 18 Oct 1998 19:41:25 +0200 (MET DST) |
| |
> I need test reports, particularly for non-i386 architectures (alpha, > sparc, sparc64). In particular I need a sparc/sparc64 person to inspect > and test my check_asm changes.
Looks mostly fine on sparc32/sparc64, just this was needed:
--- ./arch/sparc/kernel/Makefile.mec Sun Oct 18 18:39:26 1998 +++ ./arch/sparc/kernel/Makefile Sun Oct 18 19:00:55 1998 @@ -96,7 +96,7 @@ check_asm: dummy $(SH) ./check_asm.sh thread tmp.i check_asm.c @echo 'return 0; }' >> check_asm.c @rm -f tmp.[ci] - $(CC) -o check_asm check_asm.c + $(CC) -D__SMP__ -o check_asm check_asm.c ./check_asm >> asm_offsets.h @rm -f check_asm check_asm.c @echo "" >> asm_offsets.h --- ./arch/sparc64/kernel/Makefile.mec Sun Oct 18 18:59:57 1998 +++ ./arch/sparc64/kernel/Makefile Sun Oct 18 18:58:40 1998 @@ -116,7 +116,7 @@ check_asm: dummy @rm -f tmp.[ci] #$(CC) -o check_asm check_asm.c # <hack> Until we can do this natively, a hack has to take place - $(CC) $(CMODEL_CFLAG) -ffixed-g4 -S -o check_asm.s check_asm.c + $(CC) $(CMODEL_CFLAG) -D__SMP__ -ffixed-g4 -S -o check_asm.s check_asm.c $(HOSTCC) -Wa,-Av9a -o check_asm check_asm.s @rm -f check_asm.s # </hack> In fact, latest vger adds one more section of asm_offsets.h stuff for debugging SMP spinlocks, but that just means copying the stuff you've done for two chunks to the third one. That's not in 1.2.125, so I think your patch with the above fix is just fine. If you manage to get that patch in, we can fix any small glitches like this one. > > A lot of people have asked me whether this is going into 2.2. That's not > my decision. I think that after proper testing, including non-i386 > testing, it would be good for 2.2. It's short; it actually cleans up > the kernel rather than complicating it; and it makes a lot of people's > lives easier.
I'd be very happy to see this nice patch go into 2.1.12[6-9]. It would clean several things up, e.g. stuff like if CONFIG_SUN4 is defined, then CONFIG_SMP can be define_bool n, etc.
Cheers, Jakub ___________________________________________________________________ Jakub Jelinek | jj@sunsite.mff.cuni.cz | http://sunsite.mff.cuni.cz Administrator of SunSITE Czech Republic, MFF, Charles University ___________________________________________________________________ Ultralinux - first 64bit OS to take full power of the UltraSparc Linux version 2.1.125 on a sparc64 machine (498.80 BogoMips). ___________________________________________________________________ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |