lkml.org 
[lkml]   [1998]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Dynamic IP hack
Date
From
Hello!

> And as usual I forgot to append it. But now I did.
.....
> + struct device *dev;
> +
> + int want_rewrite = sysctl_ip_dynaddr & 4 || (sysctl_ip_dynaddr & 3 && sk->state == TCP_SYN_SENT);

Did you read my comment there?

Such kind of tricks become dangerous,
when they overstep some reasonable limit.

Could you move all this under some CONFIG_* option?
Also, seems, this patch does not guarantee, that socket in established
state is not mangled. Not good.

Alexey

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:45    [from the cache]
©2003-2011 Jasper Spaans