lkml.org 
[lkml]   [1998]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.1.125 Show stopper list: Draft
On Tue, 13 Oct 1998, Rik van Riel wrote:

>> If we are not OOM and __get_free_pages() return 0, it means that
>> it's buggy (at least in _not_ GFP_ATOMIC context).
>
>It can also mean something else, but I think I've explained

If it' s something else (there is plenty of memory) __get_free_pages() is
buggy. We are failing a memory allocation while we should not fail because
there are 500Mbyte of RAM/swap free.

If __get_free_pages() would fail when not OOM you would noticed that, be
quiet.

>Not really, with your patch there's a slightly increased
>chance of killing a random process when there's still some
>swap free. My patch removes the randomness _and_ the unneeded
^^^^^^^^^
Please reproduce. Be sure that until somebody will tell me a way to
reproduce on his machine the failed memory allocation I will not touch one
bit in my code.

Andrea Arcangeli


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:45    [W:0.195 / U:6.660 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site