Messages in this thread Patches in this message | | | Subject | Re: [FIXES] 2.1.125 | Date | Sat, 10 Oct 1998 02:48:24 -0400 | From | Adam Sulmicki <> |
| |
Sorry, I should have tested it more thoroughly. Here are updated, correct, patches. [btw: can someone explain me why in linux kernel I can't declare var inside of the proc, but instead it has to be at beginning of it. I think in 'normal' c programs you can do that]
Here are corrected two first patches. They are against pristine 125 kernel. The 3rd patch remains unchanged.
=========================================================== --- scripts/lxdialog/menubox.c-ORIG Sat Oct 10 02:12:15 1998 +++ scripts/lxdialog/menubox.c Sat Oct 10 02:42:15 1998 @@ -60,8 +60,11 @@ static void print_item (WINDOW * win, const char *item, int choice, int selected, int hotkey) { - int i, j; + int j; char menu_item[menu_width+1]; +#if OLD_NCURSES + int i; +#endif strncpy(menu_item, item, menu_width); menu_item[menu_width] = 0; =========================================================== --- scripts/lxdialog/textbox.c-ORIG Sat Oct 10 02:11:55 1998 +++ scripts/lxdialog/textbox.c Sat Oct 10 02:41:37 1998 @@ -451,8 +451,11 @@ static void print_line (WINDOW * win, int row, int width) { - int i, y, x; + int y, x; char *line; +#if OLD_NCURSES + int i; +#endif line = get_line (); line += MIN (strlen (line), hscroll); /* Scroll horizontally */ =========================================================== Adam Sulmicki writes:
->The third one is a problem when compiling UMSDOS. It does not ->show up for everyone. I suspect is that may be due to some ->obscure GCC bug. HOWEVER, in mine case it is a problem with ->kernel, not gcc. -> ->The issue is that umsdos_dentry_operations is declared as -> 'extern foo umsdos_dentry_operations' ->in two other files. However, in the dir.c it is declared as ->'static foo umsdos_dentry_operations'. Those two signatures ->does not match, and in mine case are correctly flagged as ->errors. -> ->=========================================================== ->--- fs/umsdos/dir.c-ORIG Fri Oct 9 18:23:32 1998 ->+++ fs/umsdos/dir.c Fri Oct 9 18:23:53 1998 ->@@ -44,7 +44,7 @@ -> } -> } -> ->-static struct dentry_operations umsdos_dentry_operations = ->+struct dentry_operations umsdos_dentry_operations = -> { -> umsdos_dentry_validate, /* d_validate(struct dentry *) */ -> NULL, /* d_hash */ ->=========================================================== -> -> ->-Adam -> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |