This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Thu May 30 00:55:44 2024 Received: from miriam.fuller.edu (miriam.fuller.edu [206.1.27.4]) by herbie.ucs.indiana.edu (8.8.5/8.8.5) with SMTP id IAA26785 for ; Sun, 1 Jun 1997 08:34:13 -0500 (EST) Received: from vger.rutgers.edu [128.6.190.2] (root) by miriam.fuller.edu with esmtp (Exim 1.624 #1) id 0wYAWz-0002p3-00 (Debian); Sun, 1 Jun 1997 06:18:45 -0700 Received: by vger.rutgers.edu id <971418-343>; Sun, 1 Jun 1997 09:09:59 -0400 Received: from fb4-1112.uni-muenster.de ([128.176.105.132]) by vger.rutgers.edu with ESMTP id <971347-343>; Sun, 1 Jun 1997 09:09:43 -0400 Received: (from joachim@localhost) by fb4-1112.uni-muenster.de (8.8.0/8.8.0) id PAA27571; Sun, 1 Jun 1997 15:13:52 +0200 From: Joachim Gassen Message-Id: <199706011313.PAA27571@fb4-1112.uni-muenster.de> Subject: [PATCH]: g_NCR5380.c 2.1.42 as module To: linux-kernel@vger.rutgers.edu, drew@colorado.edu, K.Lentin@cs.monash.edu.au Date: Sun, 1 Jun 1997 15:13:52 +0200 (MET DST) Cc: joachim@fb4-1112.uni-muenster.de (Joachim Gassen) X-Mailer: ELM [version 2.4 PL25] Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Sender: owner-linux-kernel@vger.rutgers.edu Precedence: bulk Hey all I have had some problems with the g_NCR5380 module and the latest kernels (about kernel > 2.1.37) due to unresolved symbols. 2.1.42 finally failed to compile with the following messages: gcc -D__KERNEL__ -I/usr/src/linux-vanilla/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -D__SMP__ -pipe -fno-strength-reduce -m486 -malign-loops=2 -malign-jumps=2 -malign-functions=2 -DCPU=586 -D__SMP__ -DMODULE -c -o g_NCR5380.o g_NCR5380.c g_NCR5380.c: In function eneric_NCR5380_proc_info': g_NCR5380.c:658: `dev' undeclared (first use this function) g_NCR5380.c:658: (Each undeclared identifier is reported only once g_NCR5380.c:658: for each function it appears in.) g_NCR5380.c:665: `scsi_device_types' undeclared (first use this function) make[2]: *** [g_NCR5380.o] Error 1 (With or without SMP defined) The enclosed patch makes 2.1.42 compile g_NCR5380 as a module again. The unresolved symbols are gone, too. The module now works for me (NCR53C400a and a patch from Ingmar Baumgart see http://www.schwaben.de/home/bgt/). Could someone with deeper knowledge please have a look at this and enlighten me whether I did something completely braindead. (btw: who is the current maintainer for this code?) Thanks Joachim -- Joachim Gassen v: 0251-63664 f/d: 63617 isdn: 63625 joachim@fb4-1112.uni-muenster.de Ls f. BWL, insb. IUR, Universitaetsstr. 14-16, 48143 Muenster voice: 0251-8321901 fax: 0251-8322018 11joga@wiwi.uni-muenster.de diff -3 -c -r linux-vanilla/drivers/scsi/g_NCR5380.c linux-patched/drivers/scsi/g_NCR5380.c *** linux-vanilla/drivers/scsi/g_NCR5380.c Sun Jun 1 14:25:12 1997 --- linux-patched/drivers/scsi/g_NCR5380.c Sat May 31 18:36:03 1997 *************** *** 619,625 **** struct Scsi_Host *scsi_ptr; Scsi_Cmnd *ptr; struct NCR5380_hostdata *hostdata; ! cli(); for (scsi_ptr = first_instance; scsi_ptr; scsi_ptr=scsi_ptr->next) --- 686,692 ---- struct Scsi_Host *scsi_ptr; Scsi_Cmnd *ptr; struct NCR5380_hostdata *hostdata; ! Scsi_Device *dev; cli(); for (scsi_ptr = first_instance; scsi_ptr; scsi_ptr=scsi_ptr->next) diff -3 -c -r linux-vanilla/drivers/scsi/scsi.h linux-patched/drivers/scsi/scsi.h *** linux-vanilla/drivers/scsi/scsi.h Sun Jun 1 14:25:12 1997 --- linux-patched/drivers/scsi/scsi.h Sat May 31 18:48:18 1997 *************** *** 37,43 **** #endif #define MAX_SCSI_DEVICE_CODE 10 ! extern void scsi_make_blocked_list(void); extern volatile int in_scan_scsis; extern const unsigned char scsi_command_size[8]; --- 37,44 ---- #endif #define MAX_SCSI_DEVICE_CODE 10 ! extern const char *const scsi_device_types[MAX_SCSI_DEVICE_CODE]; ! extern void scsi_make_blocked_list(void); extern volatile int in_scan_scsis; extern const unsigned char scsi_command_size[8]; diff -3 -c -r linux-vanilla/drivers/scsi/scsi_syms.c linux-patched/drivers/scsi/scsi_syms.c *** linux-vanilla/drivers/scsi/scsi_syms.c Fri Jan 3 10:33:26 1997 --- linux-patched/drivers/scsi/scsi_syms.c Sat May 31 14:06:30 1997 *************** *** 72,76 **** --- 72,77 ---- EXPORT_SYMBOL(scsi_hosts); EXPORT_SYMBOL(scsi_devicelist); EXPORT_SYMBOL(scsi_devices); + EXPORT_SYMBOL(scsi_device_types); #endif /* CONFIG_MODULES */