lkml.org 
[lkml]   [1997]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subjectgroups (was: pre-patch-2.0.31?)
In article <199705070924.FAA04845@jenolan.caipgeneral>,
davem@jenolan.rutgers.edu ("David S. Miller") writes:
> It wish it was that simple for me to cook up a patch but it is not, I
> would need something like:
>
> cvs diff -exclude-tons-of-sparc-local-hacks

A propos Sparc: I still have a problem with groups on sparc-linux:

I'm in several groups (/etc/group) but some of them don't work (i.e. I
don't have the apropriate rights). I know this was mentioned before and I
think the following code in the task_struct was blamed for it:

include/linux/sched.h:203
int groups[NGROUPS];
^^^

I think this should be "gid_t" which is unsigned short (16 bit vs. 32)

Is there any reason to continue with "int"? Was this corrected in 2.1.x?
Can this be changed in 2.0.31 without breaking other things?


Greetings Rainer


PS: The complete patch as I found it in news/kernel-list is:

--- linux/kernel/sys.c.orig Sat Nov 16 06:11:18 1996
+++ linux/kernel/sys.c Tue Nov 19 18:42:40 1996
@@ -699,7 +699,7 @@
asmlinkage int sys_getgroups(int gidsetsize, gid_t *grouplist)
{
int i;
- int * groups;
+ gid_t * groups;

if (gidsetsize < 0)
return -EINVAL;
--- linux/include/linux/sched.h.orig Tue Nov 19 18:37:50 1996
+++ linux/include/linux/sched.h Tue Nov 19 18:46:58 1996
@@ -200,7 +200,7 @@
int session;
/* boolean value for session group leader */
int leader;
- int groups[NGROUPS];
+ gid_t groups[NGROUPS];
/*
* pointers to (original) parent process, youngest child, younger sibling,
* older sibling, respectively. (p->father can be replaced with
--- linux/include/asm-i386/param.h.orig Tue Aug 1 11:08:17 1995
+++ linux/include/asm-i386/param.h Tue Nov 19 18:46:23 1996
@@ -12,7 +12,7 @@
#endif

#ifndef NOGROUP
-#define NOGROUP (-1)
+#define NOGROUP (gid_t)(-1)
#endif

#define MAXHOSTNAMELEN 64 /* max length of hostname */
--- linux/include/asm-alpha/param.h.orig Sun Mar 24 05:09:37 1996
+++ linux/include/asm-alpha/param.h Tue Nov 19 18:49:19 1996
@@ -12,7 +12,7 @@
#endif

#ifndef NOGROUP
-#define NOGROUP (-1)
+#define NOGROUP (gid_t)(-1)
#endif

#define MAXHOSTNAMELEN 64 /* max length of hostname */
--- linux/include/asm-mips/param.h.orig Wed Jan 18 01:54:13 1995
+++ linux/include/asm-mips/param.h Tue Nov 19 18:50:19 1996
@@ -12,7 +12,7 @@
#endif

#ifndef NOGROUP
-#define NOGROUP (-1)
+#define NOGROUP (gid_t)(-1)
#endif

#define MAXHOSTNAMELEN 64 /* max length of hostname */
--- linux/include/asm-m68k/param.h.orig Wed Dec 27 15:47:20 1995
+++ linux/include/asm-m68k/param.h Tue Nov 19 18:49:51 1996
@@ -12,7 +12,7 @@
#endif

#ifndef NOGROUP
-#define NOGROUP (-1)
+#define NOGROUP (gid_t)(-1)
#endif

#define MAXHOSTNAMELEN 64 /* max length of hostname */
--- linux/include/asm-ppc/param.h.orig Sat Nov 25 12:49:06 1995
+++ linux/include/asm-ppc/param.h Tue Nov 19 18:50:48 1996
@@ -12,7 +12,7 @@
#endif

#ifndef NOGROUP
-#define NOGROUP (-1)
+#define NOGROUP (gid_t)(-1)
#endif

#define MAXHOSTNAMELEN 64 /* max length of hostname */
--- linux/include/asm-sparc/param.h.orig Fri Nov 24 21:32:19 1995
+++ linux/include/asm-sparc/param.h Tue Nov 19 18:51:02 1996
@@ -13,7 +13,7 @@
#endif

#ifndef NOGROUP
-#define NOGROUP (-1)
+#define NOGROUP (gid_t)(-1)
#endif

#define MAXHOSTNAMELEN 64 /* max length of hostname */
\
 
 \ /
  Last update: 2005-03-22 13:39    [W:0.706 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site