Messages in this thread Patch in this message | | | Date | Fri, 12 Dec 1997 00:44:47 -0500 (EST) | From | "C. Scott Ananian" <> | Subject | ppp-mschap problems & fix. |
| |
-----BEGIN PGP SIGNED MESSAGE-----
The patch that Manuel Galan posted for ppp-2.3.2 and kernel 2.1.69+ has a bug in the MS-CHAP code. If you're using PPP to access Microsoft servers, you will be interested in the attached patch to pppd/chap_ms.c.
Manuel, have you submitted your patch to the ppp maintainers? I will leave the integration of this bug fix into your patch up to you. --Scott - -------------------
- --- ppp-2.3.2/pppd/chap_ms.c.orig Thu Dec 11 23:54:44 1997 +++ ppp-2.3.2/pppd/chap_ms.c Fri Dec 12 00:17:36 1997 @@ -265,8 +265,8 @@ MDbegin(&md4Context); MDupdate(&md4Context, unicodePassword, secret_len * 2 * 8); /* Unicode is 2 bytes/char, *8 for bit count */ - - - - MDupdate((u_char *) hash, &md4Context); /* Tell MD4 we're done */ + MDupdate(&md4Context, unicodePassword, 0); /* Tell MD4 we're done */ + memcpy(hash, md4Context.buffer, sizeof(hash)); if (low_byte_first == -1) low_byte_first = (htons((unsigned short int)1) != 1);
-----BEGIN PGP SIGNATURE----- Version: 2.6.3a Charset: noconv iQCVAwUBNJDPU73Z92aFrZ7tAQFr/AQAnGJLmvWPz2BXeBulpPhBHDU6rKYwYeb9 HZatTpf2M8vR6oKpIQdhFF+ksHyxPNEnVs0e3NxOQXw+Mfnd9nnYdzl72HMd6r9w BqdVgrDcjeAKwoNPT6eyUzuOohJEi+gGbTE4mczYi2EeuybQA7ibbynQGCxfu0oV ytjR1yqLCk4= =wohp -----END PGP SIGNATURE-----
| |