Messages in this thread | | | Date | Wed, 10 Dec 1997 16:45:14 -0400 | From | "Garst R. Reese" <> | Subject | Re: Linux 2.1.72 - a few oddities |
| |
Brian says: ---------------------------------------------------------- From: Brian M Grunkemeyer <bg2k@CMU.EDU> Date: Tue, 9 Dec 1997 22:35:44 -0500 (EST) Subject: Re: Linux 2.1.72 - a few oddities.
Excerpts from internet.computing.linux-kernel: 10-Dec-97 Linux 2.1.72 - a few oddities. by David Woodhouse@cam.ac.u > - /* Free device too !! - AC FIXME: CHECK THIS IS RIGHT */ > - if (devc) > + if (!devc) > vfree(devc);
Doesn't this now only vfree devc if it is 0, as opposed to freeing it if it is allocated? Looks like you introduced a memory leak. If you really want to be picky, try:
if (NULL != devc) [snip] ------------------------------------------- Look a little higher in the code and you will see: if (devc == NULL) return; So why not just vfree(devc); -- Garst
| |