lkml.org 
[lkml]   [1996]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: NFS caching patch.
Date

Hello!

>
> Ok, this is _exactly_ why I didn't check the mtime in the first place,
> and just to explain WHY this patch is bad bad bad, I'll walk you through
> it.
>

Linus, you missed something. Please, look at my patch again.
Your comments are not about it!
The only correct note is about race condition between getattr and write,
but it is the cause that I wrote the comment on NFSv3!
(Well, maybe this comment is pretty obscure.)

1. It does not stop old invalidation scheme.
I never touch read_cache_mtime/jiffies, so that
if mtime was changed, not depending who changed it,
cache is flushed.

2. It does not trash cache. Really, it is the main idea
of the patch and you missed it.

3. It is correct, I bet 8)8)

Alexey Kuznetsov.


\
 
 \ /
  Last update: 2005-03-22 13:38    [W:0.507 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site