lkml.org 
[lkml]   [1996]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: new goo for acct.h struct?
Date
From
> 
> I'd like to bounce around an idea.
>
> This has always bugged me, maybe it's bugged you...
>
> Currently, the standard acct struct in acct.h doesn't include pid and
> ppid. Considering that the structure was originally intended for process
> accounting and chargebacks (and the like), this was understandable.
>
> Adding these two fields seems like a lightweight way to get some
> additional logging useful for security analysis without alot of work.

Not only, for that. You remember the flock message ?
In the first version you only get a pid of the process, no name.
With lastcomm and a pid in struct acct it would be easier to detect.

>
> It looks like the only side-effect to adding these two fields is that
> existing progs that use the struct to read acct files would need to be
> recompiled.
>
> Any comments?

I vote for it, also we should reserve some spare longs in the accounting
record, for future extentions, or a length/version field.
In the later case we have to make some changes to the accounting utils,
but than it is possible to handle different versions of accounting records.

>
> Ideally, the ac_comm field should be replaced with something that
> includes the command-line args, but I'll leave that discussion for
> another day. ;-)
>

Than we need variable sized records ...

> --
> From owner-linux-kernel-outgoing@vger.rutgers.edu Tue Jun 25 07:13:17 1996
Received: from orchard.washtenaw.cc.mi.us (orchard.washtenaw.cc.mi.us [198.111.176.4]) by herbie.ucs.indiana.edu (8.6.12/8.6.12) with ESMTP id HAA20924 for <linuxkernel@herbie.ucs.indiana.edu>; Tue, 25 Jun 1996 07:13:17 -0500
Received: from vger.rutgers.edu by orchard.washtenaw.cc.mi.us (8.6.10/2.3)
with ESMTP id IAA00581; Tue, 25 Jun 1996 08:10:35 -0400
Received: by vger.rutgers.edu id <106215-11720>; Tue, 25 Jun 1996 07:52:10 -0500
Message-Id: <199606251005.MAA05825@ceres.tat.physik.uni-tuebingen.de>
From: koenig@tat.physik.uni-tuebingen.de (Harald Koenig)
Subject: Re: Boot messages (Was: Re: Ideas for v2.1) (fwd)
To: js10039@cam.ac.uk
Date: Tue, 25 Jun 1996 12:00:55 +0200 (MET DST)
Cc: linux-kernel@vger.rutgers.edu
In-Reply-To: <E0uXrGG-0007cY-00@hammer.thor.cam.ac.uk> from "John Sullivan" at Jun 23, 96 04:39:40 pm
X-Mailer: ELM [version 2.4 PL23]
Content-Type: text
Content-Length: 2530
Sender: owner-linux-kernel@vger.rutgers.edu
Precedence: bulk

> Hey - who says the penguin business is just noise and not real
> development?
>
> I now present to you, a real live penguin boot-logo, with the
> following caveats:
> o It's a complete hack. Use at your own risk.
> o It does some nasty things to vga hardware, so although it will
> probably work on most vga compatible hardware, ega may be
> be pushing it a little. Working over a serial console is right
> out - don't even try it.
> o Other than that, dunno. Should work. I like it. YMMV.
> The logo is the official Larry Ewing one.

your patch increase the hsync frequency from 31.5 kHz to 35.4 kHz
for normal 80x25 or 80x28 text modes since you don't change the pixel
clock. below is a fix which should work resonablely for VGA cards
(since VGA requires clocks #0 and #1 to be 25 and 28 MHz for 8/9 pixel
characters).


Harald

-------------------------------------------------------------------------------
--- linux/drivers/char/console.c~ Tue Jun 25 11:29:11 1996
+++ linux/drivers/char/console.c Tue Jun 25 11:20:41 1996
@@ -2405,7 +2405,7 @@
unsigned char pengofnt[(PENG_H+32)*PENG_W],olfnt[16384];
unsigned short olscr[PENG_W*((PENG_H+7)/8)];
unsigned char pengop[17][3];
-int penguon=0,pengych,pengrch,peng9px;
+int penguon=0,pengych,pengrch,peng9px,pengmisc;

static inline void pdelay(unsigned long q)
{
@@ -2462,6 +2462,9 @@
inb(0x3da);
outb(0x33,0x3c0);
outb(t&0xf0,0x3c0);
+ pengmisc = inb(0x3cc); /* save clock select bits */
+ if ((pengmisc & 0x0c) == 0x04) /* 28.322 MHz for 720 HSIZE */
+ outb(pengmisc & ~4, 0x3c2); /* 25.175 MHz for 640 HSIZE */
peng9px = 1;
} else peng9px = 0;
pengon = 1;
@@ -2560,6 +2563,7 @@
inb(0x3da);
outb(0x33,0x3c0);
outb((t&0xf0)|8,0x3c0);
+ outb(pengmisc, 0x3c2); /* restore clock select bits */
udelay(1000000);
}
pengon = 0;
-------------------------------------------------------------------------------
--
All SCSI disks will from now on ___ _____
be required to send an email notice 0--,| /OOOOOOO\
24 hours prior to complete hardware failure! <_/ / /OOOOOOOOOOO\
\ \/OOOOOOOOOOOOOOO\
\ OOOOOOOOOOOOOOOOO|//
Harald Koenig, \/\/\/\/\/\/\/\/\/
Inst.f.Theoret.Astrophysik // / \\ \
koenig@tat.physik.uni-tuebingen.de ^^^^^ ^^^^^

\
 
 \ /
  Last update: 2005-03-22 13:37    [W:0.078 / U:4.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site