lkml.org 
[lkml]   [1996]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: 1.99.14 & duplicate NE2000 (fwd)
Date
Forwarding a message from David Hinds:
> Ummm, I don't think this is how request_region() works. A second call
> to request_region() for an already-allocated region will silently
> fail: it will not replace the old entry with the new one.
>
> I think it would probably be a good idea for request_region() to
> return a success/failure indication. I wonder why it doesn't, but I
> wrote it a long time ago and don't remember what I was thinking at the
> time. Maybe I did it that way to be compatible with its predecessor,
> snarf_region().

I fixed request_region() and friends months ago, even finding and fixing
a race condition. I mailed the patch to Linus, but I guess it got lost
in his mailbox.

Anyway soon after Andrew E Mileski started to get into PnP support so
I passed my changes on to him and he's generalised the whole area and
worked them into a fix. I'm surprised to find his changes didn't get
into the 1.3.x tree. PLEASE put them in, and preferably into 2.0.x !

Nick.
--
Kralizec Dialup Internet System Data: +61-2-837-1183, 837-1868
Zeta Microcomputer Software Fax: +61-2-837-3753 Voice: 837-1397
P.O. Box 177, Riverstone NSW 2765 http://www.kralizec.net.au/


\
 
 \ /
  Last update: 2005-03-22 13:37    [W:0.026 / U:9.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site