lkml.org 
[lkml]   [1996]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subjectdrivers/scsi/advansys won't compile
Date
And this is due to the BYTE and WORD types that got imported from 
<linux/amigaffs.h>.

It is generaly bad practice to pollute the headers with all these standard
types - Linux should enforce one set of types (already available) and avoid
private ones in common headers.

As the number of kernel componnents grows, it would be nice if people limit
the number of types and #defines in headers when these are not necessary
outside the driver - I often see people breaking all the definitions for a
driver into the header which is used only by that driver. This header
sometimes ends up as a globally visible one.

In this specific case (see subject) the amigaffs header got in through the
general fs.h header.



\
 
 \ /
  Last update: 2005-03-22 13:37    [W:0.039 / U:2.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site