lkml.org 
[lkml]   [1996]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: serious bug in filemap.c
Stephen C. Tweedie (sct@dcs.ed.ac.UK) wrote:
>
> wait_on_page() should not return until all the outstanding IO on the
> page has been completed, and the page is now unlocked. At this point,
> !PageUptodate(page) is not an indication that IO is still outstanding
> --- it is an indication that there was an error in the IO and the page
> has not been read correctly.
>
> We definitely have to deal with this condition, but I think the right
> way would be to treat it as an error rather than simply resubmitting
> the IO request.
>

You forgot about NFS. When asynchronous request will be timed out
we will get not locked and not uptodate page with error flag set.

BTW I stole this fix from generic_file_read function.
If it is broken, generic_file_read is broken too.

Alexey Kuznetsov


\
 
 \ /
  Last update: 2005-03-22 13:37    [W:0.028 / U:5.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site