[lkml]   [1996]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
SubjectMinor bug in PPP driver


I've found a minor bug in the ppp driver. The value of tx_queue_len was
set to 0. The problem is that the current networking code
will just drop a packet on the floor if there is no "room" in the
device queue when it tries to put it into the queue. Since the queue
is just a linked list I didn't see any problems with making the value
of tx_queue_len non-zero. [This is the case in pretty much all the
other networking drivers.] In any case this improves the full bore
TCP speed across my PPP link by about 10%.

-- eric

Eric Schenk www:
Department of Computer Science email:
University of Toronto

--------------------- CUT HERE --------------------------------------------
diff -u -r linux-1.99.4/drivers/net/ppp.c linux/drivers/net/ppp.c
--- linux-1.99.4/drivers/net/ppp.c Thu May 16 04:57:57 1996
+++ linux/drivers/net/ppp.c Fri May 17 01:31:56 1996
@@ -400,6 +400,7 @@
dev->get_stats = ppp_dev_stats;
dev->do_ioctl = ppp_dev_ioctl;
dev->addr_len = 0;
+ dev->tx_queue_len = 10;
dev->type = ARPHRD_PPP;

for (indx = 0; indx < DEV_NUMBUFFS; indx++)
--------------------- CUT HERE --------------------------------------------

 \ /
  Last update: 2005-03-22 13:37    [W:0.025 / U:1.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site