lkml.org 
[lkml]   [1996]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 1.99.3 (pre2.0.3) ooops
On Mon, 13 May 1996, Linus Torvalds wrote:

> On Mon, 13 May 1996, David Flood wrote:
> >
> > Here's the kernel log, relevant area of System.map, and .config for a
> > reproduceable error that occurs when shutdown is invoked (-r or -h doesn't
> > matter).
>
> It's the unix domain socket garbage collect code - it's been in the
> kernel for some time, but it's been disabled. Duh.
>
> [ btw, it gets a lot easier for me if the kernel dump is prettied up a
> bit - ksymoops does this quite well. It's very hard to go throw "raw
> data" with very little hints on system map information etc ]

I saw and compiled ksymoops but couldn't figure out how to invoke it. Every
time I tried I got a core dump.

As for the following patch, it seems to have fixed it. I've rebooted and
shutdown several times and the error (which occured on every reboot or
shutdown) hasn't re-appeared. Thanks for the fix.

> There is at least one missing initialization that might cause this, so if
> you can make the error occur at will, please apply this small patch and
> tell me if it helps..
>
> Linus
> -----
> diff -u --recursive --new-file pre2.0.3/linux/net/unix/af_unix.c linux/net/unix/af_unix.c
> --- pre2.0.3/linux/net/unix/af_unix.c Mon May 13 23:02:54 1996
> +++ linux/net/unix/af_unix.c Mon May 13 23:02:15 1996
> @@ -505,6 +505,7 @@
> return err;
> skb->sk=sk; /* So they know it is us */
> skb->free=1;
> + skb->h.filp=NULL;
> sk->state=TCP_CLOSE;
> unix_mkname(sunaddr, addr_len);
> other=unix_find_other(sunaddr->sun_path, &err);

=============================================================================
dcflood@u.washington.edu



\
 
 \ /
  Last update: 2005-03-22 13:37    [W:0.096 / U:4.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site