lkml.org 
[lkml]   [1996]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PNP patch into kernel when?

On Thu, 5 Dec 1996, Philip Blundell wrote:

>
> On Wed, 4 Dec 1996, Andrew E. Mileski wrote:
>
> > I think this squashes all the complaints put forward so far.
> > If not, please remind me.
>
> I've just been looking at the PnP patch in slightly more detail. Is there
> any chance you could use a slightly more conventional layout style? I
> find that function definitions laid out as
>
> /*
> * Find an empty region entry.
> */
> static hwres_entry_t * find_empty
> (
> void
> )
> {
> int i;
> ...
> }
>
> are a bit visually jarring, and they don't match any other part of the
> kernel that I know of. Since I imagine many people may want to work on
> the resource manager, it seems polite to stick to the standard coding
> style.

I agree. A consistant style must be follwed throughout the code or major
confusion will result.

-R

-----------------------------------------------------------------------
Robert S. Liesenfeld <>< | Mail/News/UUCP Administrator
xunil@bitstream.net IRC:Xunil96 | Programmer
http://www2.bitstream.net/~xunil/ | Network Engineer
finger for PGP public key | Die-hard Linux Addict
"Foink." | Bitstream Underground, Mpls, MN


\
 
 \ /
  Last update: 2005-03-22 13:38    [W:0.043 / U:3.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site