lkml.org 
[lkml]   [1996]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: name space analysis and patches, 2.1.17
Date

Gerd Knorr (kraxel@cs.tu-berlin.de) wrote:

: Seems you did'nt got the point why they are *not* static: They allow to
: give ioport and interrupt while loading a module using something like

: insmod io=0x260 irq=11 wrt.o

: And probably this is inside a #ifdef MODULE, so you hav'nt problems with
: name clashes when compiling it into the kernel...

insmod will let you set the value of a static symbol -- there is no
need to make a parameter external. I've always coded these as static
on moral grounds.

I think cleaning up all these external definitions is an excellent
idea, even if it doesn't cause any obvious problems with modules as
they are currently used. My reason is that I'm setting up a system
for linking modules into the kernel, and in this case, these name
clashes *will* cause trouble.

-- Dave Hinds

\
 
 \ /
  Last update: 2005-03-22 13:38    [W:0.092 / U:0.836 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site