lkml.org 
[lkml]   [1996]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: name space analysis and patches, 2.1.17

In linux.dev.kernel you write:

>diff -ur linux-2.1.17.orig/drivers/char/wdt.c linux/drivers/char/wdt.c
>--- linux-2.1.17.orig/drivers/char/wdt.c Fri Dec 13 01:51:09 1996
>+++ linux/drivers/char/wdt.c Mon Dec 23 14:13:53 1996
>@@ -48,8 +48,8 @@
> * You must set these - there is no sane way to probe for this board.
> */
>
>-int io=0x240;
>-int irq=14;
>+static int io=0x240;
>+static int irq=14;
>
> #define WD_TIMO (100*60) /* 1 minute */

Seems you did'nt got the point why they are *not* static: They allow to
give ioport and interrupt while loading a module using something like

insmod io=0x260 irq=11 wrt.o

And probably this is inside a #ifdef MODULE, so you hav'nt problems with
name clashes when compiling it into the kernel...

Gerd

\
 
 \ /
  Last update: 2005-03-22 13:38    [W:0.075 / U:2.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site