[lkml]   [1996]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Socket header file

Alan Modra writes:
> > (Richard B. Johnson)
> > /usr/include/linux/socket.h: unsigned char cmsg_data[0];
> > This should probably be:
> > unsigned char *cmsg_data;
> No, definitely not. It's correct as it is. The structure is
> dynamically allocated with cmsg_data[] a variable length array.

I have complained to Linus about this a few times before, with no
response. The problem with the above construct is that you cannot
compile with gcc -Wall -pedantic-errors
Note that I'm referring to compiling *user code*, not kernel
code. Does this particular structure have to be visible outside the
kernel? If not, can someone please put an #ifdef around it?
If this structure needs to be visible outside the kernel, then this
structure needs to be reconsidered. It is really *extremely annoying*
to have to edit the file whenever I download a new kernel, just so I
can compile my userland networking code.



 \ /
  Last update: 2005-03-22 13:38    [W:1.491 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site