Messages in this thread |  | | From | "Peter T. Breuer" <> | Subject | Re: prob. with irq.c in 2.0.24? | Date | Thu, 31 Oct 1996 18:05:58 +0000 (WET) |
| |
"A month of sundays ago Peter T. Breuer wrote:" > > -malign-jumps=2 -malign-functions=2 -DCPU=586 -c -o irq.o irq.c > irq.c:583: macro `ACK_FIRST' used with just one arg > make[1]: *** [irq.o] Error 1 > make[1]: Leaving directory `/usr/src/linux-2.0.24/arch/i386/kernel' > make: *** [linuxsubdirs] Error 2 > > > .. now I'll go away and investigate what is up. This is gcc 2.7.2 (elf) > compiling a pretty standard kernel under libc 5.4.9 with IDE and sound.
OK - this one is simple.
I use the PC speaker driver. It uses ACK_FIRST(0x01) (or whatever) in a modification to irq.c. That is broken by the change to ACK_FIRST in 2.0.15.
HOWEVER - this looks like a bug. The only change made to ACK_FIRST in patches 2.0.1 to 2.0.24 is in the definition. Are you (Linus) saying that there was previously no use made of this macro? If so, why change it?
# grep ACK_FIRST ~ptb/ftp/kernel-patch/patch-2.0.* /home/ptb/ftp/kernel-patch/patch-2.0.15:-#define ACK_FIRST(mask) \ /home/ptb/ftp/kernel-patch/patch-2.0.15:+#define ACK_FIRST(mask,nr) \
Peter T. Breuer ,--------------------------------------------------------------------------- |Departamento de Ingenieria de Sistemas Telematicos, Universidad Politecnica |de Madrid, Escuela Tecnica Superior de Ingenieros de Telecomunicacion, |Ciudad Universitaria, E--28040 Madrid, SPAIN. |Tel. Office : +34 (1)336 6831 | Fax : +34 (1)543 2077 or 336 7333 |Internet : <ptb@eng.cam.ac.uk, ptb@comlab.ox.ac.uk, ptb@dit.upm.es> | URL : http://www.dit.upm.es:80/~ptb/ `---------------------------------------------------------------------------
|  |