lkml.org 
[lkml]   [2008]   [May]   [9]   [last100]   RSS-feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Complete thread (EXPERIMENTAL)
Patch in this message
/
DateFri, 9 May 2008 23:12:05 +0100 (BST)
From"Maciej W. Rozycki" <>
Subject[PATCH] RTC/watchdog: M41T80: Fix a potential use of unitialized data
Digg This
Watchdog handlers within the driver make use of "save_client" -- make sure it has been initalized before the handlers are registered.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
 It should be obvious.  Please apply.
Maciej

patch-2.6.26-rc1-20080505-m41t80-save_client-14

[view this diff only]
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/drivers/rtc/rtc-m41t80.c linux-2.6.26-rc1-20080505/drivers/rtc/rtc-m41t80.c
--- linux-2.6.26-rc1-20080505.macro/drivers/rtc/rtc-m41t80.c	2008-05-05 02:55:40.000000000 +0000
+++ linux-2.6.26-rc1-20080505/drivers/rtc/rtc-m41t80.c	2008-05-09 22:00:13.000000000 +0000
@@ -803,6 +803,7 @@ static int m41t80_probe(struct i2c_clien
 
 #ifdef CONFIG_RTC_DRV_M41T80_WDT
 	if (clientdata->features & M41T80_FEATURE_HT) {
+		save_client = client;
 		rc = misc_register(&wdt_dev);
 		if (rc)
 			goto exit;
@@ -811,7 +812,6 @@ static int m41t80_probe(struct i2c_clien
 			misc_deregister(&wdt_dev);
 			goto exit;
 		}
-		save_client = client;
 	}
 #endif
 	return 0;


\
ISP Services
Valid XHTML 1.0!\ /
Valid CSS! Last update: 2008-05-10 00:15    [W:0.059 / U:0.150 seconds]
©2003-2005 Jasper Spaans