lkml.org 
[lkml]   [2008]   [May]   [7]   [last100]   RSS-feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Complete thread (EXPERIMENTAL)
/
DateWed, 7 May 2008 15:11:10 -0700 (PDT)
FromLinus Torvalds <>
SubjectRe: [PATCH 01 of 11] mmu-notifier-core
Digg This


On Wed, 7 May 2008, Andrea Arcangeli wrote:

As far as I can tell, authorship has been destroyed by at least two of the patches (ie Christoph seems to be the author, but Andrea seems to have dropped that fact).

I can't follow this, please be more specific.

The patches were sent to lkml without *any* indication that you weren't actually the author.

So if Andrew had merged them, they would have been merged as yours.
That "locking" code is also too ugly to live, at least without some serious arguments for why it has to be done that way. Sorting the locks? In a vmalloc'ed area? And calling this something innocuous like "mm_lock()"? Hell no.

That's only invoked in mmu_notifier_register, mm_lock is explicitly documented as heavyweight function.

Is that an excuse for UTTER AND TOTAL CRAP?

Linus



\
ISP Services
Valid XHTML 1.0!\ /
Valid CSS! Last update: 2008-05-08 00:21    [W:0.343 / U:0.000 seconds]
©2003-2005 Jasper Spaans