![]() | |||||||||||
Messages in this thread Complete thread (EXPERIMENTAL) |
... No, it's not an irq_disable() thing, directly.
What lockdep is saying is that sky2_poll() is taking napi->poll_lock for writing with softirqs enabled, but net_rx_action() takes the same lock from within softirq context. If sky2_poll() always takes napi->poll_lock under local_irq_disable() then that would be a lockdep bug. sky2_poll() doesn't take napi->poll_lock; this lock is taken by netpoll_poll() before calling sky2_poll(). And before this hardirqs are disabled in write_msg(). So, theoretically lockdep could be right if sky2_poll() would enable irqs after this. (If it were done in netpoll - lockdep should warn before or after sky2_poll() call.) But I really can't see any such possibility in sky2_poll(). Regards, Jarek P. | ||||||||||
![]() | |||||||||||
| Last update: 2008-03-27 09:55 [W:0.075 / U:0.110 seconds] ©2003-2005 Jasper Spaans | |||||||||||