lkml.org 
[lkml]   [2008]   [Mar]   [26]   [last100]   RSS-feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Complete thread (EXPERIMENTAL)
/
SubjectRe: [patch] pci: revert "PCI: remove transparent bridge sizing"
FromBenjamin Herrenschmidt <>
DateThu, 27 Mar 2008 09:27:28 +1100
Digg This

On Wed, 2008-03-26 at 22:07 +0000, Alan Cox wrote:
> > PCI bridges at zero is perfectly valid indeed and I'm sure we have that
> > around at least for IO space. In fact, I'm surprised you don't have that
> > on x86. Typically, things like an HT segment with a P2P bridge and
> > behind that bridge an ISA bridge could well have the P2P bridge with a
> > resource forwarding 0...0x1000 IO downstream for example even on x86
> > no ? (I'm not -that- familiar with the crazyness of legacy ISA on x86
> > but I've definitely seen such setup on other archs).
On a PC system 0x00-0xFF are motherboard resources (sometimes chipset, some even swallowed by the CPU in certain cases) so 0 as disabled is sort of safe but as shown by the pci_enable_device_bars replacement code - not a good idea neccessarily.

A lot of driver code does assume 0 == unavailable/off/disabled including large chunks of serial, ata, ide and probably other subsystems.

True, and we do try to avoid allocating resources at 0 most of the time, but it happens, and in the case of bridges, it can make somewhat sense (more in fact than for devices I'd say).

Cheers,
Ben.





\
ISP Services
Valid XHTML 1.0!\ /
Valid CSS! Last update: 2008-03-26 23:33    [W:0.115 / U:0.030 seconds]
©2003-2005 Jasper Spaans