lkml.org 
[lkml]   [2008]   [Mar]   [26]   [last100]   RSS-feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Complete thread (EXPERIMENTAL)
/
FromMariusz Kozlowski <>
SubjectRe: sparc64 BUG: using smp_processor_id() in preemptible
DateWed, 26 Mar 2008 13:10:12 +0100
Digg This
Hello,

From: Mariusz Kozlowski <m.kozlowski@tuxland.pl> Date: Wed, 26 Mar 2008 12:46:53 +0100

Ok it worked. Now I get a bunch of these:

BUG: using smp_processor_id() in preemptible [00000000] code: pidof/2471 caller is flush_ptrace_access+0xc0/0x1a0

Here ya go:

commit f6a843d939ade435e060d580f5c56d958464f8a5
Author: David S. Miller <davem@davemloft.net> Date: Wed Mar 26 04:51:12 2008 -0700

[SPARC64]: flush_ptrace_access() needs preemption disable.
Based upon a report by Mariusz Kozlowski.

Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/arch/sparc64/kernel/ptrace.c b/arch/sparc64/kernel/ptrace.c index bcf58ec..aaae865 100644
--- a/arch/sparc64/kernel/ptrace.c
+++ b/arch/sparc64/kernel/ptrace.c
@@ -70,6 +70,8 @@ void flush_ptrace_access(struct vm_area_struct *vma, struct page *page, if (tlb_type == hypervisor)
return;

+ preempt_disable();
+
#ifdef DCACHE_ALIASING_POSSIBLE
/* If bit 13 of the kernel address we used to access the * user page is the same as the virtual address that page @@ -108,6 +110,8 @@ void flush_ptrace_access(struct vm_area_struct *vma, struct page *page, for (; start < end; start += icache_line_size)
flushi(start);
}
+
+ preempt_enable();
}

enum sparc_regset {

And this one also worked. Now I have a nice clean dmesg :)
Thanks,

Mariusz



\
ISP Services
Valid XHTML 1.0!\ /
Valid CSS! Last update: 2008-03-26 13:13    [W:0.097 / U:0.130 seconds]
©2003-2005 Jasper Spaans