lkml.org 
[lkml]   [2008]   [Feb]   [8]   [last100]   RSS-feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Complete thread (EXPERIMENTAL)
Patch in this message
/
FromBalaji Rao <>
Subject[REGRESSION] kobject handling in cpufreq
DateSat, 9 Feb 2008 00:52:40 +0530
Digg This
Hi greg,

I encountered a regression in linux-2.6.git which prevented the system from shutting down. I found that it was 'waiting_for_completion' on kobj_unregister.The same thing happened when I tried to take CPUs offline.
git-bisect pointed me to this commit :

commit c10997f6575f476ff38442fa18fd4a0d80345f9d
Author: Greg Kroah-Hartman <gregkh@suse.de>
Date: Thu Dec 20 08:13:05 2007 -0800

    Kobject: convert drivers/* from kobject_unregister() to kobject_put()
In the file drivers/cpufreq/cpufreq.c, you have not replaced one occurrence of kobject_unregister with kobject_put. Apparently its because of the kobject_put in the subsequent line.
@@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device * sys_dev)
unlock_policy_rwsem_write(cpu);

- kobject_unregister(&data->kobj);
\
ISP Services
Valid XHTML 1.0!\ /
Valid CSS! Last update: 2008-02-08 20:29    [W:0.344 / U:0.150 seconds]
©2003-2005 Jasper Spaans