Warning: XSLTProcessor::transformToXml() [function.XSLTProcessor-transformToXml]: Warning: string contains a character that is out of range! Substituting "?". in /srv/lkml.org/scripts/getmail.php on line 209
LKML: Valdis.Kletnieks@vt ...: Re: [PATCH] linux/hdsmart.h: fix goofups
lkml.org 
[lkml]   [2008]   [Feb]   [18]   [last100]   RSS-feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Complete thread (EXPERIMENTAL)
/
SubjectRe: [PATCH] linux/hdsmart.h: fix goofups
From Valdis.Kletnieks@vt ...
DateMon, 18 Feb 2008 00:06:37 -0500
Digg This
On Sun, 17 Feb 2008 12:17:20 EST, "Robert P. J. Day" said:
if that header file isn't used by any kernel code, why bother having a check for __KERNEL__ in the first place? it's being exported to userspace unchecked:

include/linux/Kbuild:header-y += hdsmart.h

so why not just toss that check entirely? otherwise, you're going to get a header file exported to userspace that has a superfluous __KERNEL__ test in it.

Umm... if the kernel isn't using it, why are we bothering to export it to userspace at all? Or is the kernel using something *else* that should be going to userspace instead?

[unhandled content-type:application/pgp-signature]
\
ISP Services
Valid XHTML 1.0!\ /
Valid CSS! Last update: 2008-02-18 06:09    [W:0.288 / U:0.040 seconds]
©2003-2005 Jasper Spaans