lkml.org 
[lkml]   [2008]   [Feb]   [16]   [last100]   RSS-feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Complete thread (EXPERIMENTAL)
/
DateFri, 15 Feb 2008 23:27:38 -0600
FromOlof Johansson <>
SubjectRe: pci_device_id definition cleanups
Digg This
On Sat, Feb 16, 2008 at 03:23:36AM +0100, Sam Ravnborg wrote:
On Sat, Feb 16, 2008 at 12:21:40AM +0100, Jonas Bonn wrote:
I've done some work on cleaning up the definitions of pci_device_id to make them "static const" (where possible) and to make sure they go into __devinitconst. There are about 350 changes of the type shown in the diff at the end of this mail.

???All these changes are in my public GIT tree at:

git://www.southpole.se/~jonas/git/linux.git

(Based on 2.6.25-rc2)

In addition to these pci_device_id changes, there are a few changesets that move "const" data from __devinitdata to __devinitconst.
The tree above builds with both allmodconfig and allyesconfig.

Hi Jonas.

Can I ask you to try the same with ARCH=powerpc
(or alpha or ia64).
Becasue it is for these architectures we see issues with defining data const.

I pulled his tree and tried building on powerpc w/ gcc 4.3, it passed.
I'm not too excited about the extremely long open-coded variable definitions everywhere now though. Wouldn't it be better to just do a macro for it?

Something like:

#define PCI_DEVICE_TABLE(_var) static const struct pci_device_id _var[] __devinitconst
And then just:

PCI_DEVICE_TABLE(mydevice_tbl) = {
	...
};

-Olof



\
ISP Services
Valid XHTML 1.0!\ /
Valid CSS! Last update: 2008-02-16 06:27    [W:0.322 / U:0.170 seconds]
©2003-2005 Jasper Spaans