lkml.org 
[lkml]   [2008]   [Jan]   [22]   [last100]   RSS-feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Complete thread (EXPERIMENTAL)
/
SubjectCONFIG_MARKERS
FromJon Masters <>
DateTue, 22 Jan 2008 14:13:55 -0500
Digg This
Yo,

I notice in module.c:

#ifdef CONFIG_MARKERS
	if (!mod->taints)
		marker_update_probe_range(mod->markers,
			mod->markers + mod->num_markers, NULL, NULL);
#endif
Is this an attempt to not set a marker for proprietary modules? If so, then this really should be the following conditional instead, because, really we're not guaranteeing there won't be other taints (e.g. in RHEL we already have the module signing patch, and then there's also the TAINT_FORCED_MODULE, which arguably isn't a "taint" for markers):
#ifdef CONFIG_MARKERS
	if (!(mod->taints & TAINT_PROPRIETARY_MODULE))
		marker_update_probe_range(mod->markers,
			mod->markers + mod->num_markers, NULL, NULL);
#endif
Or am I missing something?

Jon.





\
ISP Services
Valid XHTML 1.0!\ /
Valid CSS! Last update: 2008-01-22 19:17    [W:1.615 / U:0.090 seconds]
©2003-2005 Jasper Spaans