![]() | |||||||||||
Messages in this thread Complete thread (EXPERIMENTAL)Patch in this message |
While testing 2.6.20-rc3 on a machine with some CK804 chipsets, we noticed that quirk_nvidia_ck804_msi_ht_cap() was not detecting HT MSI capabilities anymore. It is actually caused by the MSI mapping on the root chipset being the 2nd HT capability in the chain. pci_find_ht_capability() does not seem to find anything but the first HT cap correctly, because it forgets to increment the position before looking for the next cap. The following patch seems to fix it. At least, this prooves that having a ttl is good idea since the machine would have been stucked in an infinite loop if we didn't have a ttl :) The patch should go in 2.6.20 since this quirk was working fine in 2.6.19. --- [PATCH] increment pos before looking for the next cap in __pci_find_next_ht_capWe have to pass pos + PCI_CAP_LIST_NEXT to __pci_find_next_cap_ttl to get the next HT cap instead of the same one again. Signed-off-by: Brice Goglin <brice@myri.com> Signed-off-by: Andrew J. Gallatin <gallatin@myri.com> --- drivers/pci/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Index: linux-rc/drivers/pci/pci.c [view this diff only] =================================================================== --- linux-rc.orig/drivers/pci/pci.c 2007-01-05 23:34:59.000000000 +0100 +++ linux-rc/drivers/pci/pci.c 2007-01-05 23:35:24.000000000 +0100 @@ -254,7 +254,8 @@ if ((cap & mask) == ht_cap) return pos; - pos = __pci_find_next_cap_ttl(dev->bus, dev->devfn, pos, + pos = __pci_find_next_cap_ttl(dev->bus, dev->devfn, + pos + PCI_CAP_LIST_NEXT, PCI_CAP_ID_HT, &ttl); } | ||||||||||
![]() | |||||||||||
| Last update: 2007-01-05 23:15 [W:0.121 / U:1.000 seconds] ©2003-2005 Jasper Spaans | |||||||||||